mrhid6/vantage
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 22 Wiki Activity

chore(adminsite): remove the frontend test suite

Browse Source 
Removes vitest, React Testing Library, the config, the setup file and all
eleven test files, plus the test scripts and dev dependencies. Done at the
user's direction; it matches the rest of the repo, which has no automated
tests in any language.

All eleven were observed passing before removal, and their assertions are
kept in the plan as acceptance criteria to check by hand rather than deleted
outright -- they are the clearest statement of what each component has to do.

Consequence worth stating: Task 16's manual pass is now the only verification
that exists for spec 4. Four behaviours it must cover carefully, because each
is easy to break invisibly: 404-not-403 scoping, the expired card naming what
still works, relink disabling at zero, and the blob fallback when a download
fails.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
mrhid6
2026-07-25 21:19:34 +01:00
co-authored by Claude Opus 5
parent cefbac625c
commit 24060b2c5a
9 changed files with 24 additions and 2485 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/superpowers/plans/2026-07-25-admin-site.md
+21
View File
@@ -8,6 +8,27 @@
**Tech Stack:** Next.js 16.2.9 App Router, React 18.3.1, Tailwind 3.4, TanStack Query 5, TypeScript 5.5, Vitest + React Testing Library (new to this repo), Go 1.26 for tasks 1–2.
## Amendment, 2026-07-25: no automated frontend tests
**The test suite was removed at the user's direction after tasks 1–12 were
built.** `vitest`, React Testing Library, `vitest.config.ts`, `test/setup.ts` and
all eleven `*.test.tsx` files are gone, along with the `test` scripts and dev
dependencies. This matches the rest of the repo, which has no automated tests in
any language.
The TDD steps below (write the failing test, watch it fail, implement, watch it
pass) are kept as written because they record *what each component is required to
do* — the assertions are the specification, and they were all observed passing
before removal. Treat them as acceptance criteria to check by hand, not as files
to create.
**What this costs:** spec 4's tests 1–10 no longer run anywhere, so **Task 16 is
now the only verification that exists**. Do not skip it or shorten it, and be
especially careful with the four things the deleted tests covered that are easy
to get subtly wrong and invisible when broken: the 404-not-403 scoping, the
expired-card copy naming what still works, the relink allowance disabling at
zero, and the licence-blob fallback when a download fails.
## Global Constraints
- **The token set is `site/`'s, copied verbatim.** `adminsite/app/globals.css` carries the same custom properties, with the same names and the same hex values, as `site/app/globals.css` — brand navy accent `#0b2a58` light / `#5b9be8` dark, `--up #2f8a60` / `--down #c6462f` / `--pend #b0801f`, the same `--shadow`, the same `--s--1`…`--s-4` clamp scale, `--rail: 1200px`. **When `site/`'s tokens change, change these in the same commit** — they are one visual system in two apps, and there is nothing that enforces the match automatically.