chore: replace em dashes with hyphens, add no-em-dash rule to CLAUDE.md

internal/workloads/control_windows.go

@@ -9,7 +9,7 @@ import (
 	"gitea.hostxtra.co.uk/vantage/vantage-agent/internal/winexec"
 )
 
-// AgentUnit is the service this agent runs as — the NSSM service name written
+// AgentUnit is the service this agent runs as - the NSSM service name written
 // by installer/setup.ps1. Change one, change the other.
 const AgentUnit = "VantageAgent"
 

internal/workloads/docker.go

@@ -30,8 +30,8 @@ const dockerTimeout = 30 * time.Second
 // dockerInspect is the subset of `docker inspect` output we read.
 //
 // We use inspect rather than `docker ps --format '{{json .}}'` because ps
-// reports health and uptime inside a human Status string — "Up 2 hours
-// (healthy)" — and anything built on that is parsing English that is
+// reports health and uptime inside a human Status string - "Up 2 hours
+// (healthy)" - and anything built on that is parsing English that is
 // localised, reworded between releases, and silently different for a paused or
 // restarting container. inspect gives typed fields instead.
 type dockerInspect struct {
@@ -59,7 +59,7 @@ type dockerInspect struct {
 }
 
 // collectDocker enumerates containers. It returns ok=false with an empty error
-// string when Docker is simply not installed — the common case on this fleet,
+// string when Docker is simply not installed - the common case on this fleet,
 // and not a fault.
 func collectDocker(ctx context.Context) ([]Workload, bool, string) {
 	if _, err := exec.LookPath("docker"); err != nil {

internal/workloads/logs_windows.go

@@ -25,7 +25,7 @@ func logsPlatform(ctx context.Context, kind, id string, tail int) (string, error
 
 		// Timestamps are formatted PowerShell-side rather than left to
 		// ConvertTo-Json, whose DateTime rendering differs between PowerShell
-		// versions — one of them emits /Date(1699...)/.
+		// versions - one of them emits /Date(1699...)/.
 		//
 		// $ErrorActionPreference = 'SilentlyContinue' because Get-WinEvent
 		// treats "no events matched" as a terminating error, and a quiet
@@ -38,7 +38,7 @@ func logsPlatform(ctx context.Context, kind, id string, tail int) (string, error
 
 		// ProviderName includes the host-wide Service Control Manager, so a
 		// -MaxEvents cap of exactly tail would apply to the combined stream
-		// before parseEvents narrows SCM rows down to this service — on a
+		// before parseEvents narrows SCM rows down to this service - on a
 		// host with busy service churn the target's own events could be
 		// squeezed out of the window entirely. Over-fetch instead, hard-capped
 		// so a pathological host cannot pull an unbounded batch across the
@@ -76,7 +76,7 @@ ConvertTo-Json -InputObject @($rows) -Depth 3 -Compress
 }
 
 // serviceDisplayName resolves a service's display name, which is what Service
-// Control Manager events name it by. An empty answer is fine — the filter then
+// Control Manager events name it by. An empty answer is fine - the filter then
 // matches on the service name alone.
 func serviceDisplayName(ctx context.Context, id string) string {
 	out, err := winexec.Run(ctx,

internal/workloads/systemd_linux.go

@@ -15,7 +15,7 @@ const systemdTimeout = 30 * time.Second
 var excludedPrefixes = []string{"systemd-", "user@", "user-", "session-", "init.scope"}
 
 // collectUnits enumerates services in two passes, because "running or
-// failed" and "enabled but stopped" are different questions — and an enabled
+// failed" and "enabled but stopped" are different questions - and an enabled
 // unit that is not running is exactly the one worth seeing.
 func collectUnits(ctx context.Context) ([]Workload, bool, string) {
 	if _, err := exec.LookPath("systemctl"); err != nil {

internal/workloads/units_other.go

@@ -1,6 +1,6 @@
 //go:build !linux && !windows
 
-// The build constraint is load-bearing — see updates_other.go.
+// The build constraint is load-bearing - see updates_other.go.
 package workloads
 
 import (

internal/workloads/winparse.go

@@ -19,7 +19,7 @@ type winService struct {
 }
 
 // exitCodeNeverStarted is ERROR_SERVICE_NEVER_STARTED. A stopped service
-// carrying it has not failed — it has not run since boot — and painting that
+// carrying it has not failed - it has not run since boot - and painting that
 // red would cry wolf on every host.
 const exitCodeNeverStarted = 1077
 
@@ -52,8 +52,8 @@ func servicePath(pathName string) string {
 }
 
 // exeBoundaryIndex finds the first ".exe" (case-insensitive) in s that
-// actually ends the executable name — followed by end-of-string, whitespace,
-// or a double quote — rather than continuing into a longer segment such as
+// actually ends the executable name - followed by end-of-string, whitespace,
+// or a double quote - rather than continuing into a longer segment such as
 // ".exec". It returns -1 when no such occurrence exists, so a path like
 // `C:\Program Files\Ad.exec\tool.com -flag` is not misparsed by matching the
 // ".exe" inside "Ad.exec" and silently dropping the real filename.
@@ -113,8 +113,8 @@ func parseServices(jsonText, systemRoot string) ([]Workload, error) {
 			continue
 		}
 
-		// The wire shape is shared with the systemd collector — both report
-		// under kind "unit" — so the state word has to be too, or the UI
+		// The wire shape is shared with the systemd collector - both report
+		// under kind "unit" - so the state word has to be too, or the UI
 		// (which colours and filters on it, and does so before it knows
 		// which platform sent the row) needs two vocabularies for one kind.
 		// running/stopped/failed become active/inactive/failed to match.
@@ -168,7 +168,7 @@ type winEvent struct {
 // applied before SCM rows are narrowed down to this service would squeeze the
 // target's own events out of the window on a host with busy service churn.
 // tail is therefore applied here, AFTER filtering and AFTER the oldest-first
-// reversal, keeping the last tail lines — the most recent lines are the ones
+// reversal, keeping the last tail lines - the most recent lines are the ones
 // worth keeping, matching capLog's front-trim reasoning in the shared
 // logs.go.
 func parseEvents(jsonText, serviceName, displayName string, tail int) (string, error) {

internal/workloads/winparse_test.go

@@ -13,7 +13,7 @@ func TestServicePath(t *testing.T) {
 		{`"C:\no\args.exe"`, `C:\no\args.exe`},
 		{``, ``},
 		// ".exe" appearing inside an earlier segment ("Ad.exec") must not be
-		// treated as the end of the executable — that would drop the real
+		// treated as the end of the executable - that would drop the real
 		// filename and arguments.
 		{`C:\Program Files\Ad.exec\tool.com -flag`, `C:\Program`},
 		// An unterminated quote falls back to the unquoted handling on the
@@ -72,7 +72,7 @@ func TestParseServicesFilters(t *testing.T) {
 	}
 }
 
-// 1077 means "no attempt to start since boot" — a clean stopped service, not a
+// 1077 means "no attempt to start since boot" - a clean stopped service, not a
 // failure, and reporting it red would cry wolf on every host.
 func TestParseServicesExitCode1077(t *testing.T) {
 	in := `[{"Name":"Idle","DisplayName":"Idle","State":"Stopped","StartMode":"Auto","PathName":"C:\\Idle\\i.exe","ExitCode":1077}]`

internal/workloads/workloads.go

@@ -37,7 +37,7 @@ func Collect(ctx context.Context) Result {
 //
 // It sorts first: `docker ps` output ordering is not stable, and an
 // ordering-sensitive hash would resend the full list every 60 seconds forever
-// — a cost visible only as traffic.
+// - a cost visible only as traffic.
 //
 // StartedAt is deliberately excluded: it does not change while a container
 // runs, and including it would add nothing. Restarts IS included, because a