feat: associated task status with task list not space

backend/internal/application/services/task_service.go

@@ -46,8 +46,8 @@ func NewTaskService(
 	}
 }
 
-func (s *TaskService) ensureDefaultStatuses(ctx context.Context, spaceID bson.ObjectID) error {
-	statuses, err := s.taskStatusRepo.ListStatuses(ctx, spaceID)
+func (s *TaskService) ensureDefaultStatuses(ctx context.Context, taskListID bson.ObjectID) error {
+	statuses, err := s.taskStatusRepo.ListStatuses(ctx, taskListID)
 	if err != nil {
 		return err
 	}
@@ -66,10 +66,10 @@ func (s *TaskService) ensureDefaultStatuses(ctx context.Context, spaceID bson.Ob
 
 	for idx, status := range defaults {
 		if err := s.taskStatusRepo.CreateStatus(ctx, &entities.TaskStatus{
-			SpaceID: spaceID,
-			Name:    status.name,
-			Color:   status.color,
-			Order:   idx,
+			TaskListID: taskListID,
+			Name:       status.name,
+			Color:      status.color,
+			Order:      idx,
 		}); err != nil {
 			return err
 		}
@@ -142,9 +142,9 @@ func (s *TaskService) validateNoteLinks(ctx context.Context, spaceID bson.Object
 	return nil
 }
 
-func (s *TaskService) validateStatus(ctx context.Context, spaceID, statusID bson.ObjectID) (*entities.TaskStatus, error) {
+func (s *TaskService) validateStatus(ctx context.Context, taskListID, statusID bson.ObjectID) (*entities.TaskStatus, error) {
 	status, err := s.taskStatusRepo.GetStatusByID(ctx, statusID)
-	if err != nil || status.SpaceID != spaceID {
+	if err != nil || status.TaskListID != taskListID {
 		return nil, errors.New("invalid task status")
 	}
 	return status, nil
@@ -165,11 +165,11 @@ func (s *TaskService) resolveDepthAndParent(ctx context.Context, spaceID bson.Ob
 	return depth, nil
 }
 
-func (s *TaskService) isAdjacentStatusMove(ctx context.Context, spaceID, currentStatusID, requestedStatusID bson.ObjectID) (bool, error) {
+func (s *TaskService) isAdjacentStatusMove(ctx context.Context, taskListID, currentStatusID, requestedStatusID bson.ObjectID) (bool, error) {
 	if currentStatusID == requestedStatusID {
 		return true, nil
 	}
-	statuses, err := s.taskStatusRepo.ListStatuses(ctx, spaceID)
+	statuses, err := s.taskStatusRepo.ListStatuses(ctx, taskListID)
 	if err != nil {
 		return false, err
 	}
@@ -205,10 +205,6 @@ func (s *TaskService) CreateTask(ctx context.Context, spaceID, userID bson.Objec
 		return nil, errors.New("insufficient permissions")
 	}
 
-	if err := s.ensureDefaultStatuses(ctx, spaceID); err != nil {
-		return nil, err
-	}
-
 	parentTaskID, err := toObjectIDPtr(req.ParentTaskID)
 	if err != nil {
 		return nil, errors.New("invalid parent task")
@@ -226,6 +222,10 @@ func (s *TaskService) CreateTask(ctx context.Context, spaceID, userID bson.Objec
 		return nil, err
 	}
 
+	if err := s.ensureDefaultStatuses(ctx, taskListID); err != nil {
+		return nil, err
+	}
+
 	noteLinks, err := toObjectIDs(req.NoteLinks)
 	if err != nil {
 		return nil, err
@@ -234,7 +234,7 @@ func (s *TaskService) CreateTask(ctx context.Context, spaceID, userID bson.Objec
 		return nil, err
 	}
 
-	statuses, err := s.taskStatusRepo.ListStatuses(ctx, spaceID)
+	statuses, err := s.taskStatusRepo.ListStatuses(ctx, taskListID)
 	if err != nil {
 		return nil, err
 	}
@@ -252,7 +252,7 @@ func (s *TaskService) CreateTask(ctx context.Context, spaceID, userID bson.Objec
 		if parseErr != nil {
 			return nil, errors.New("invalid task status")
 		}
-		if _, validateErr := s.validateStatus(ctx, spaceID, parsedStatusID); validateErr != nil {
+		if _, validateErr := s.validateStatus(ctx, taskListID, parsedStatusID); validateErr != nil {
 			return nil, validateErr
 		}
 		statusID = parsedStatusID
@@ -299,7 +299,7 @@ func (s *TaskService) GetTaskByID(ctx context.Context, spaceID, taskID, userID b
 		return nil, errors.New("task not found")
 	}
 
-	status, err := s.validateStatus(ctx, spaceID, task.StatusID)
+	status, err := s.validateStatus(ctx, task.TaskListID, task.StatusID)
 	if err != nil {
 		return nil, err
 	}
@@ -331,9 +331,6 @@ func (s *TaskService) ListTasks(
 	if err := s.requireSpaceAccess(ctx, userID, spaceID); err != nil {
 		return nil, err
 	}
-	if err := s.ensureDefaultStatuses(ctx, spaceID); err != nil {
-		return nil, err
-	}
 
 	filters := map[string]any{}
 	if taskListID != nil && strings.TrimSpace(*taskListID) != "" {
@@ -403,23 +400,33 @@ func (s *TaskService) ListTasksLinkedToNote(ctx context.Context, spaceID, noteID
 	if _, err := s.noteRepo.GetNoteByID(ctx, noteID); err != nil {
 		return nil, errors.New("note not found")
 	}
-	statuses, err := s.taskStatusRepo.ListStatuses(ctx, spaceID)
-	if err != nil {
-		return nil, err
-	}
-	statusByID := map[bson.ObjectID]*entities.TaskStatus{}
-	for _, status := range statuses {
-		statusByID[status.ID] = status
-	}
 
 	tasks, err := s.taskRepo.ListTasks(ctx, spaceID, map[string]any{"note_links": noteID})
 	if err != nil {
 		return nil, err
 	}
 
+	// Collect statuses per task list
+	statusCache := map[bson.ObjectID]map[bson.ObjectID]*entities.TaskStatus{}
+	getStatus := func(taskListID, statusID bson.ObjectID) *entities.TaskStatus {
+		byID, ok := statusCache[taskListID]
+		if !ok {
+			statuses, err := s.taskStatusRepo.ListStatuses(ctx, taskListID)
+			if err != nil {
+				return nil
+			}
+			byID = make(map[bson.ObjectID]*entities.TaskStatus, len(statuses))
+			for _, st := range statuses {
+				byID[st.ID] = st
+			}
+			statusCache[taskListID] = byID
+		}
+		return byID[statusID]
+	}
+
 	result := make([]*dto.TaskWithStatusDTO, 0, len(tasks))
 	for _, task := range tasks {
-		status := statusByID[task.StatusID]
+		status := getStatus(task.TaskListID, task.StatusID)
 		if status == nil {
 			continue
 		}
@@ -509,10 +516,10 @@ func (s *TaskService) UpdateTask(ctx context.Context, spaceID, taskID, userID bs
 		if parseErr != nil {
 			return nil, errors.New("invalid status")
 		}
-		if _, err := s.validateStatus(ctx, spaceID, statusID); err != nil {
+		if _, err := s.validateStatus(ctx, task.TaskListID, statusID); err != nil {
 			return nil, err
 		}
-		adjacent, err := s.isAdjacentStatusMove(ctx, spaceID, task.StatusID, statusID)
+		adjacent, err := s.isAdjacentStatusMove(ctx, task.TaskListID, task.StatusID, statusID)
 		if err != nil {
 			return nil, err
 		}
@@ -582,7 +589,7 @@ func (s *TaskService) TransitionTaskStatus(ctx context.Context, spaceID, taskID,
 		return nil, errors.New("task not found")
 	}
 
-	statuses, err := s.taskStatusRepo.ListStatuses(ctx, spaceID)
+	statuses, err := s.taskStatusRepo.ListStatuses(ctx, task.TaskListID)
 	if err != nil {
 		return nil, err
 	}
@@ -816,17 +823,24 @@ func (s *TaskService) DeleteTaskList(ctx context.Context, spaceID, taskListID, u
 		return err
 	}
 
+	if err := s.taskStatusRepo.DeleteStatusesByTaskListID(ctx, taskListID); err != nil {
+		return err
+	}
+
 	return s.taskListRepo.DeleteTaskList(ctx, taskListID)
 }
 
-func (s *TaskService) ListStatuses(ctx context.Context, spaceID, userID bson.ObjectID) ([]*dto.TaskStatusDTO, error) {
+func (s *TaskService) ListStatuses(ctx context.Context, spaceID, taskListID, userID bson.ObjectID) ([]*dto.TaskStatusDTO, error) {
 	if err := s.requireSpaceAccess(ctx, userID, spaceID); err != nil {
 		return nil, err
 	}
-	if err := s.ensureDefaultStatuses(ctx, spaceID); err != nil {
+	if err := s.validateTaskList(ctx, spaceID, taskListID); err != nil {
 		return nil, err
 	}
-	statuses, err := s.taskStatusRepo.ListStatuses(ctx, spaceID)
+	if err := s.ensureDefaultStatuses(ctx, taskListID); err != nil {
+		return nil, err
+	}
+	statuses, err := s.taskStatusRepo.ListStatuses(ctx, taskListID)
 	if err != nil {
 		return nil, err
 	}
@@ -837,7 +851,7 @@ func (s *TaskService) ListStatuses(ctx context.Context, spaceID, userID bson.Obj
 	return result, nil
 }
 
-func (s *TaskService) CreateStatus(ctx context.Context, spaceID, userID bson.ObjectID, req *dto.CreateTaskStatusRequest) (*dto.TaskStatusDTO, error) {
+func (s *TaskService) CreateStatus(ctx context.Context, spaceID, taskListID, userID bson.ObjectID, req *dto.CreateTaskStatusRequest) (*dto.TaskStatusDTO, error) {
 	if err := s.requireSpaceAccess(ctx, userID, spaceID); err != nil {
 		return nil, err
 	}
@@ -848,16 +862,19 @@ func (s *TaskService) CreateStatus(ctx context.Context, spaceID, userID bson.Obj
 	if !hasPermission {
 		return nil, errors.New("insufficient permissions")
 	}
+	if err := s.validateTaskList(ctx, spaceID, taskListID); err != nil {
+		return nil, err
+	}
 
-	statuses, err := s.taskStatusRepo.ListStatuses(ctx, spaceID)
+	statuses, err := s.taskStatusRepo.ListStatuses(ctx, taskListID)
 	if err != nil {
 		return nil, err
 	}
 	status := &entities.TaskStatus{
-		SpaceID: spaceID,
-		Name:    strings.TrimSpace(req.Name),
-		Color:   strings.TrimSpace(req.Color),
-		Order:   len(statuses),
+		TaskListID: taskListID,
+		Name:       strings.TrimSpace(req.Name),
+		Color:      strings.TrimSpace(req.Color),
+		Order:      len(statuses),
 	}
 	if status.Name == "" {
 		return nil, errors.New("status name is required")
@@ -868,7 +885,7 @@ func (s *TaskService) CreateStatus(ctx context.Context, spaceID, userID bson.Obj
 	return dto.NewTaskStatusDTO(status), nil
 }
 
-func (s *TaskService) UpdateStatus(ctx context.Context, spaceID, statusID, userID bson.ObjectID, req *dto.UpdateTaskStatusRequest) (*dto.TaskStatusDTO, error) {
+func (s *TaskService) UpdateStatus(ctx context.Context, spaceID, taskListID, statusID, userID bson.ObjectID, req *dto.UpdateTaskStatusRequest) (*dto.TaskStatusDTO, error) {
 	if err := s.requireSpaceAccess(ctx, userID, spaceID); err != nil {
 		return nil, err
 	}
@@ -881,7 +898,7 @@ func (s *TaskService) UpdateStatus(ctx context.Context, spaceID, statusID, userI
 	}
 
 	status, err := s.taskStatusRepo.GetStatusByID(ctx, statusID)
-	if err != nil || status.SpaceID != spaceID {
+	if err != nil || status.TaskListID != taskListID {
 		return nil, errors.New("task status not found")
 	}
 
@@ -896,7 +913,7 @@ func (s *TaskService) UpdateStatus(ctx context.Context, spaceID, statusID, userI
 	return dto.NewTaskStatusDTO(status), nil
 }
 
-func (s *TaskService) DeleteStatus(ctx context.Context, spaceID, statusID, userID bson.ObjectID) error {
+func (s *TaskService) DeleteStatus(ctx context.Context, spaceID, taskListID, statusID, userID bson.ObjectID) error {
 	if err := s.requireSpaceAccess(ctx, userID, spaceID); err != nil {
 		return err
 	}
@@ -908,7 +925,7 @@ func (s *TaskService) DeleteStatus(ctx context.Context, spaceID, statusID, userI
 		return errors.New("insufficient permissions")
 	}
 
-	statuses, err := s.taskStatusRepo.ListStatuses(ctx, spaceID)
+	statuses, err := s.taskStatusRepo.ListStatuses(ctx, taskListID)
 	if err != nil {
 		return err
 	}
@@ -928,10 +945,10 @@ func (s *TaskService) DeleteStatus(ctx context.Context, spaceID, statusID, userI
 		return err
 	}
 
-	return s.normalizeStatusOrder(ctx, spaceID)
+	return s.normalizeStatusOrder(ctx, taskListID)
 }
 
-func (s *TaskService) ReorderStatuses(ctx context.Context, spaceID, userID bson.ObjectID, orderedStatusIDs []string) ([]*dto.TaskStatusDTO, error) {
+func (s *TaskService) ReorderStatuses(ctx context.Context, spaceID, taskListID, userID bson.ObjectID, orderedStatusIDs []string) ([]*dto.TaskStatusDTO, error) {
 	if err := s.requireSpaceAccess(ctx, userID, spaceID); err != nil {
 		return nil, err
 	}
@@ -942,8 +959,11 @@ func (s *TaskService) ReorderStatuses(ctx context.Context, spaceID, userID bson.
 	if !hasPermission {
 		return nil, errors.New("insufficient permissions")
 	}
+	if err := s.validateTaskList(ctx, spaceID, taskListID); err != nil {
+		return nil, err
+	}
 
-	statuses, err := s.taskStatusRepo.ListStatuses(ctx, spaceID)
+	statuses, err := s.taskStatusRepo.ListStatuses(ctx, taskListID)
 	if err != nil {
 		return nil, err
 	}
@@ -965,7 +985,7 @@ func (s *TaskService) ReorderStatuses(ctx context.Context, spaceID, userID bson.
 		}
 		status := statusByID[statusID]
 		if status == nil {
-			return nil, errors.New("status id does not belong to this space")
+			return nil, errors.New("status id does not belong to this task list")
 		}
 		if _, exists := seen[statusID]; exists {
 			return nil, errors.New("duplicate status id in ordered_status_ids")
@@ -996,7 +1016,7 @@ func (s *TaskService) ReorderStatuses(ctx context.Context, spaceID, userID bson.
 		}
 	}
 
-	updatedStatuses, err := s.taskStatusRepo.ListStatuses(ctx, spaceID)
+	updatedStatuses, err := s.taskStatusRepo.ListStatuses(ctx, taskListID)
 	if err != nil {
 		return nil, err
 	}
@@ -1008,8 +1028,8 @@ func (s *TaskService) ReorderStatuses(ctx context.Context, spaceID, userID bson.
 	return result, nil
 }
 
-func (s *TaskService) normalizeStatusOrder(ctx context.Context, spaceID bson.ObjectID) error {
-	statuses, err := s.taskStatusRepo.ListStatuses(ctx, spaceID)
+func (s *TaskService) normalizeStatusOrder(ctx context.Context, taskListID bson.ObjectID) error {
+	statuses, err := s.taskStatusRepo.ListStatuses(ctx, taskListID)
 	if err != nil {
 		return err
 	}